Use external CSS file to support keyframe animations with strict content security policy #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only serious blocker I know of is that Microsoft Edge doesn't use the correct duration for fading out the spinner lines. I filed an issue for this here: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/14931071/. |
This was referenced Jan 2, 2018
…ent security policy Added a new `animation` option to choose a CSS animation name, and removed the `opacity` and `trail` options. IE 9 is no longer supported, so the legacy `fps` option has also been removed.
|
The Microsoft Edge bug is fixed in the Windows 10 April 2018 update (version 1803), so there's nothing blocking this anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
animationoption to choose a CSS animation name, and removes theopacityandtrailoptions. There is now a spin.css file that can be included to use one of the preset animations.Since IE 9 doesn't support keyframe animations, this pull request drops support for it, and also removes the
fpsoption which was only used for IE 9.Fixes #106, closes #215.