Added check if there is already a running instance of health-check.sh #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check to avoid running a new instance if there is one already running
|
Wie kommen wir hier weiter? |
jpawlowski
suggested changes
Feb 24, 2021
| RUNNING_INSTANCES=$(pgrep -f "/bin/sh -c /health-check.sh" | wc -l) | ||
|
|
||
| if [ "${RUNNING_INSTANCES}" -gt "1" ]; then | ||
| echo "Instance already running, aborting another one" |
There was a problem hiding this comment.
echoing here does not make sense as it will replace status appearance of the existing instance in docker status overview.
There was a problem hiding this comment.
From the docs
To help debug failing probes, any output text (UTF-8 encoded) that the command writes on stdout or stderr will be stored in the health status and can be queried with docker inspect. Such output should be kept short (only the first 4096 bytes are stored currently).
This output should help, if there is already a running instance of the health check to report this, that something isn't correct at all.
There was a problem hiding this comment.
How we can proceed here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check to avoid running a new instance if there is one already running