Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROMACS: Use Parrinello-Rahman barostat #97

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Conversation

HanatoK
Copy link
Collaborator

@HanatoK HanatoK commented Feb 22, 2023

New versions of GMX deprecate the use of Berendsen barostat.

This commit should solve the problem mentioned in #96.

New versions of GMX deprecate the use of Berendsen barostat.
@fhh2626
Copy link
Owner

fhh2626 commented Feb 23, 2023

PR barostat is not very stable in equilibration. Should we use MC barostat?

@HanatoK
Copy link
Collaborator Author

HanatoK commented Feb 23, 2023

@fhh2626
Have you tried it? I will run the p41 example with the Parrinello-Rahman barostat to see if it is stable.

OK. I see the warning in step 7. I will look into a better solution.

@HanatoK
Copy link
Collaborator Author

HanatoK commented Feb 25, 2023

I am testing the C-rescale, which supports both equilibration and production simulations. However, it requires GROMACS 2021 and above.

@fhh2626
Copy link
Owner

fhh2626 commented Feb 27, 2023

@fhh2626 Have you tried it? I will run the p41 example with the Parrinello-Rahman barostat to see if it is stable.

OK. I see the warning in step 7. I will look into a better solution.

Yes. I tested the PR barostat previously and it did not stable in the initial stage of equilibration.

@fhh2626
Copy link
Owner

fhh2626 commented Feb 27, 2023

So should we?

@HanatoK
Copy link
Collaborator Author

HanatoK commented Feb 27, 2023

So should we?

No. I incline to use C-rescale and will change the code. The only problem is that it requires GROMACS 2021. The simulation is still running, and I will see if the results are correct.

@HanatoK HanatoK marked this pull request as draft February 27, 2023 11:19
GMX documentation says C-rescale can be used for both equilibration and
production simulations, so we use it, as it neither prevents the
generation of MDP files nor crashes the simulations.
@HanatoK HanatoK marked this pull request as ready for review March 4, 2023 10:46
@HanatoK
Copy link
Collaborator Author

HanatoK commented Mar 4, 2023

@fhh2626
I change the default pcoupl to C-rescale, and the TPR files can be generated without errors. Simulations are stable and not crashed. Trajectories look good. The only problem is that the binding free energy (from Abl kinase SH3:p41) still cannot match the result from NAMD, which I remember it is the same as what I have tried before.

@fhh2626
Copy link
Owner

fhh2626 commented Mar 4, 2023

What do you mean "The only problem is that the binding free energy (from Abl kinase SH3:p41) still cannot match the result from NAMD"? In my previous test everything seemed good.

@HanatoK
Copy link
Collaborator Author

HanatoK commented Mar 4, 2023

What do you mean "The only problem is that the binding free energy (from Abl kinase SH3:p41) still cannot match the result from NAMD"? In my previous test everything seemed good.

Screenshot_20230304_085558

See the attached screenshot. The results are quite different from those from NAMD simulations.

@HanatoK
Copy link
Collaborator Author

HanatoK commented Mar 4, 2023

@fhh2626
I am going to run the old version (pcoupl = Berendsen) again but with -maxwarn 1 to suppress the warning, and to see if the binding free energy matches the NAMD result.

@fhh2626
Copy link
Owner

fhh2626 commented Mar 9, 2023

Did you use a stratification strategy for steps 1, 7 and 8? The use of 3, 5, 3 windows respectively for the three steps guarantees a good convergence of the simulations.

@HanatoK
Copy link
Collaborator Author

HanatoK commented Mar 10, 2023

No, but I will try it.

@HanatoK HanatoK marked this pull request as draft March 29, 2023 08:42
@fhh2626 fhh2626 marked this pull request as ready for review March 29, 2023 15:16
@fhh2626
Copy link
Owner

fhh2626 commented Mar 29, 2023

This is good for me. Can we merge this PR now?

@HanatoK
Copy link
Collaborator Author

HanatoK commented Mar 29, 2023

@fhh2626
OK. I think C-rescale is at least better than Berendsen.

@fhh2626 fhh2626 merged commit 0ba1e1e into fhh2626:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants