Pieter patch 1 (OneShot mode working) #6

PieterBosElectro · 2023-01-30T12:43:36Z

OneShot mode function:
Takes 1 converstion and waits till trigger of timer and takes another converstion

User defines in .h file:

//user commands
#define readConversionData		0b01000011; // Device address 1, incremental read starting at register address 0 (ADC Data register) 0x43
#define fullResetFastCmd		0b01111000; // Fast command to reset device 0x78
#define startConversionFastCmd  0b01101000; // Fast command to start a conversion 0x68

Void function for oneshot mode

mnemocron

I don't think the code like this runs or even compiles.
But it has good work in it that can be adapted.

mnemocron · 2023-01-30T14:28:15Z

example/Src/main.c

+	 //Use your own debug mode
+	 //Lcd_cursor(&lcd,0,9);
+	 //Lcd_string (&lcd,"ADC POR");
+     MCP3561_Init_ch0(&hspi1);


I don't see where MCP3561_Init_ch0 was defined.

My bad, i have different init for different channels.

mnemocron · 2023-01-30T14:29:11Z

example/Src/main.c

@@ -413,6 +413,61 @@ void HAL_GPIO_EXTI_Callback(uint16_t GPIO_Pin)
    	}
    }
 }
+
+/*@brief this fuction does One-Shot for MCP3564 */
+void ADC_One_Shot(SPI_HandleTypeDef *hspi)


ADC_One_Shot is not called anywhere, but much more importantly, it is not defined before.

I don't think the code like this runs or even compiles. But it has good work in it that can be adapted.

I compiles on my machine. But thais not a good reason ;)

mnemocron · 2023-01-30T14:29:42Z

example/Src/main.c

+ if ((status & 0x01) == 0x00)
+ {
+	 //Use your own debug mode
+	 //Lcd_cursor(&lcd,0,9);


Remove code fragments regarding LCD

Yo, thanks! My first code review. So thanks for the opportunity. And of course thanks for the debugging work 😃 As you can see, I can't just merge it but incorporate your input a little differently later.

Thanks! i will implement you suggestions

mnemocron · 2023-01-30T14:30:02Z

example/Src/mcp3564.c

@@ -95,6 +95,64 @@ void MCP3561_Init(SPI_HandleTypeDef *hspi){


 }
+void MCP3561_Init_One_Shot(SPI_HandleTypeDef *hspi){


Define this function in the .h file too

mnemocron · 2023-01-30T14:32:02Z

example/Src/mcp3564.c

+
+	// be careful with the bitwise or operator "|"
+	cmd[0]  = MCP3561_CONFIG0_WRITE;
+	cmd[1]  = MCP3561_CONFIG0_CLK_SEL_EXT;   // clock selection


Building the cmd bytes like this is outdated. Use the mcp3564_conf.h method.

mnemocron · 2023-01-30T14:32:57Z

example/Src/mcp3564.c

+
+	cmd[0]  = MCP3561_MUX_WRITE;
+	cmd[1]  = (MCP3561_MUX_CH_AGND << 4) | MCP3561_MUX_CH0;
+	//cmd[1]  = (MCP3561_MUX_CH_AGND << 4) | MCP3561_MUX_CH0;         //Deze werkt


Love a good Dutch comment:)

mnemocron · 2023-01-30T14:33:13Z

example/Src/mcp3564.c

+	// @see Datasheet Table 5-14 on p. 54
+
+/*
+	cmd[0] = MCP3561_SCAN_WRITE;


remove this, I guess

mnemocron · 2023-01-30T14:35:58Z

Yo, thanks! My first code review. So thanks for the opportunity.
And of course thanks for the debugging work 😃
As you can see, I can't just merge it but incorporate your input a little differently later.

PieterBosElectro added 2 commits January 30, 2023 12:30

Update main.c

25349f4

Void function for oneshot mode

Update mcp3564.c

c827eaf

PieterBosElectro changed the title ~~Pieter patch 1~~ Pieter patch 1 (OneShot mode working) Jan 30, 2023

mnemocron self-requested a review January 30, 2023 14:26

mnemocron requested changes Jan 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pieter patch 1 (OneShot mode working) #6

Pieter patch 1 (OneShot mode working) #6

PieterBosElectro commented Jan 30, 2023

mnemocron left a comment

mnemocron Jan 30, 2023

PieterBosElectro Jan 30, 2023

mnemocron Jan 30, 2023

PieterBosElectro Jan 30, 2023

mnemocron Jan 30, 2023

PieterBosElectro Jan 30, 2023

mnemocron Jan 30, 2023

PieterBosElectro Jan 30, 2023

mnemocron Jan 30, 2023

mnemocron Jan 30, 2023

mnemocron Jan 30, 2023

mnemocron commented Jan 30, 2023

		@@ -95,6 +95,64 @@ void MCP3561_Init(SPI_HandleTypeDef *hspi){


		}
		void MCP3561_Init_One_Shot(SPI_HandleTypeDef *hspi){

Pieter patch 1 (OneShot mode working) #6

Are you sure you want to change the base?

Pieter patch 1 (OneShot mode working) #6

Conversation

PieterBosElectro commented Jan 30, 2023

mnemocron left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnemocron commented Jan 30, 2023