Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add direction ltr #266

Merged
merged 2 commits into from
Jan 31, 2024
Merged

chore: add direction ltr #266

merged 2 commits into from
Jan 31, 2024

Conversation

mammad2c
Copy link
Contributor

@mammad2c mammad2c commented Aug 4, 2023

I am using this plugin in an RTL project (Persian, Arabic, and... are RTL for example and we have <html dir='rtl'>), and when the vite-plugin-checker shows up, its direction is not working properly and messages are hard to read. This is a tiny change to solve this issue and always LTR direction for the message area. You can see the problem here:

Issue:
image

After this change:
image

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2023

🦋 Changeset detected

Latest commit: 23b7e6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit 23b7e6b
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/65ba94a5774ffb00073363fd
😎 Deploy Preview https://deploy-preview-266--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mammad2c
Copy link
Contributor Author

mammad2c commented Aug 5, 2023

@fi3ework would you please re-run the failed jobs?

Copy link
Owner

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you can pass use config.overlay.panelStyle to append direction: ltr or keep the direction. I think it's good to explicitly add to the default style.

@fi3ework fi3ework merged commit b0cce16 into fi3ework:main Jan 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants