Add minimal Node model #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a complete Node object, but sufficient for writing an ingress controller.
mortenlj
requested changes
Oct 16, 2018
|
|
||
|
|
||
| class NodeStatus(Model): | ||
| addresses = ListField(dict) |
There was a problem hiding this comment.
I would prefer it if you could define the NodeAddress objects as well. While every item in the model could be described using a dict, the point of the models is to have some actual objects that can be introspected.
The same applies to NodeConditions and NodeSystemInfo below.
|
|
||
|
|
||
| class NodeSpec(Model): | ||
| externalID = OnceField(six.text_type) |
There was a problem hiding this comment.
This is tricky. In 1.8, this field was deprecated, but it will be removed in 1.13. I guess we will keep it for now.
Reading the documentation, I think this might be a ReadOnlyField, instead of a OnceField. At least in practice, since normal clients can't create a Node and set the value of the field.
|
This is included in #55, so closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a complete Node object, but sufficient for writing an
ingress controller.