fix(cookies): reverted node's getter back to raw() #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satish-ravi
reviewed
Aug 18, 2022
| const setCookie = Cookie.parse(headers?.get('set-cookie') || '') | ||
| if (setCookie) { | ||
| cookieRecord[setCookie.key] = setCookie.value | ||
| const headerSetCookies = (headers as any).raw()[ |
There was a problem hiding this comment.
Can we add a unit test for extractCookies? You can pass a mocked header object directly to _extractCookies instead of relying on login and fetch mock to mock headers
satish-ravi
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that multiple set-cookie headers are received, the old implementation of headers.get('set-cookie') would return a string sequence, making parsing difficult. Using .raw() returns an array of strings, making parsing easier.