Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't run on Node.js #2

Closed
fiatjaf opened this issue May 11, 2017 · 1 comment
Closed

doesn't run on Node.js #2

fiatjaf opened this issue May 11, 2017 · 1 comment

Comments

@fiatjaf
Copy link
Owner

fiatjaf commented May 11, 2017

Due to a totally unexpected issue with process.platform being reported as nonexistent in the instantiation of emscripten's NODEFS, an error is thrown when jq-web is run on Node.js.

I imagine that an easy solution (already tried by me with manual compiled code editing) would be to not instantiate NODEFS in any way, but perhaps fixing the process.platform would be better.

I'm asking for help on this topic at https://groups.google.com/forum/#!topic/emscripten-discuss/Ikl3qxPoFAk

If anyone seeing this has any solution or clue to a solution it will be highly appreciated.

jeffslofish added a commit to jeffslofish/jq-web that referenced this issue May 13, 2017
@fiatjaf
Copy link
Owner Author

fiatjaf commented May 14, 2017

Fixed at 5104925.

@fiatjaf fiatjaf closed this as completed May 14, 2017
fiatjaf pushed a commit that referenced this issue Oct 12, 2018
* Changed from MODULARIZE_INSTANCE to MODULARIZE so that we can pass in module functions like locateFile to support webpack
* Changed the way Module is handled in pre.js to allow functions to be passed in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant