增加 timeout 选项和相应的 renew, keys 接口 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
viemacs
commented
May 3, 2017
•
viemacs
commented
- Redis 使用 timeout (TTL) 选项时, table_name 需设置为空字符串 ""
- LevelDB 和 object/Map 现不支持 keys(), 无返回结果
xicilion
reviewed
May 3, 2017
lib/backend/Redis.js
Outdated
| @@ -2,7 +2,7 @@ var utils = require('../utils'); | |||
|
|
|||
| function getTable(conn, opts) { | |||
| var name = utils.table_name(opts); | |||
| return name ? conn.getHash(name) : conn; | |||
| return !name || name === 'kvs' ? conn : conn.getHash(name); | |||
There was a problem hiding this comment.
redis 时可以在 setup 时有 timeout 且 name 不为 '' 时抛出错误。强制要求将 name 设置为 ''，
这样可以避免程序员错误设置参数。同时也可以减少下面代码的复杂性。
|
要把 readme 修改一下 |
viemacs
changed the title
viemacs
force-pushed
the
f_expire
branch
6 times, most recently
from
460aaf4
to
88b4023
Compare
viemacs
commented
May 4, 2017
| utils.key_name(opts) + ' VARCHAR(' + utils.key_size(opts) + ') PRIMARY KEY, ' + | ||
| utils.value_name(opts) + ' VARCHAR(' + utils.value_size(opts) + '));'; | ||
| utils.value_name(opts) + ' VARCHAR(' + utils.value_size(opts) + ')' + | ||
| _v(opts, ', _timestamp BIGINT') + ');'; |
There was a problem hiding this comment.
timestamp 改为 _timestamp; 在 timeout 不为正时, 不加 时间戳 字段. 以减少冲突的可能.
|
在 sqlite, mysql, mongodb 上有增加时间戳的问题. 对 sqlite, mysql 预先定义好的表, 如果开 timeout 需要在实现上再处理一下. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.