crypto, bugfix: too large matrix size will cause crypto.randomArt to crash, #677

Author: xicilion

fibjs/src/crypto/crypto.cpp

@@ -288,7 +288,7 @@ char* randomart(const unsigned char* dgst_raw, size_t dgst_raw_len,
 result_t crypto_base::randomArt(Buffer_base* data, exlib::string title,
     int32_t size, exlib::string& retVal)
 {
-    if (size < 1)
+    if (size < 1 || size > 128)
         return CHECK_ERROR(CALL_E_OUTRANGE);
 
     exlib::string buf;

test/crypto_test.js

@@ -225,6 +225,10 @@ describe('crypto', () => {
         assert.throws(() => {
             crypto.randomArt(data, "title", 0);
         });
+
+        assert.throws(() => {
+            crypto.randomArt(undefined, '', 1064203628);
+        });
     });
 
     describe('Cipher', () => {