Stb#537 Fix field types determination for Search class #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemijRodionov
changed the title
ArtemijRodionov
force-pushed
the
stb-537-autocomplete
branch
from
ae68ce2
to
e3b2899
Compare
duker33
approved these changes
Mar 29, 2019
search/search.py
Outdated
| @@ -46,6 +46,20 @@ def trigram_search(query: str, queryset, fields: List[str]): | |||
| return queryset.annotate(similarity=trigram_query).order_by('-similarity') | |||
|
|
|||
|
|
|||
| def field_type(model, field): | |||
There was a problem hiding this comment.
up to now we had convenient to use verbs as the first word of a function name.
So, let's call it get_field_type or change this convenient.
The both is ok for me, but convenient preserving should just cheaper.
Decide it plz
search/search.py
Outdated
| @@ -46,6 +46,20 @@ def trigram_search(query: str, queryset, fields: List[str]): | |||
| return queryset.annotate(similarity=trigram_query).order_by('-similarity') | |||
|
|
|||
|
|
|||
| def field_type(model, field): | |||
| """Determine a type name of Django field.""" | |||
There was a problem hiding this comment.
it'll be true OOP to create smth like this:
class FieldMeta:
"""Django Model's field metadata."""
TEXT_TYPES = ['CharField', 'TextField']
def __init__(model, field: str):
self.model = model
self.field = field
def type() -> str:
# field_type() function code here
...
def is_text() -> bool:
return self.type() in TEXT_TYPES
If you agree with it, pdd subtask would be good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to fidals/stroyprombeton#537