Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph equality bug #202

Merged
merged 1 commit into from
Jan 11, 2022
Merged

graph equality bug #202

merged 1 commit into from
Jan 11, 2022

Conversation

ncilfone
Copy link
Contributor

What does this PR do?

fix bug where equality was checking using is (which checks memory loc) which prevents class overloading and re-mapping. Switched to a simple module + class name mapping as those should still be unique

Checklist

  • Did you adhere to PEP-8 standards?
  • Did you run black and isort prior to submitting your PR?
  • Does your PR pass all existing unit tests?
  • Did you add associated unit tests for any additional functionality?
  • Did you provide documentation (Google Docstring format) whenever possible, even for simple functions or classes?

…) which prevents class overloading and re-mapping. Switched to a simple module + class name mapping as those should still be unique
@ncilfone ncilfone added the bug Something isn't working label Jan 11, 2022
@ncilfone ncilfone self-assigned this Jan 11, 2022
@coveralls
Copy link

coveralls commented Jan 11, 2022

Pull Request Test Coverage Report for Build 1683899334

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 95.059%

Totals Coverage Status
Change from base Build 1679196849: 0.2%
Covered Lines: 1616
Relevant Lines: 1700

💛 - Coveralls

@ncilfone ncilfone merged commit 9f2d2f0 into master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants