Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alv-grid-merge-cells #77

Closed
wants to merge 0 commits into from
Closed

alv-grid-merge-cells #77

wants to merge 0 commits into from

Conversation

RTagliento
Copy link
Contributor

As reuqested....

I merged the method of this project
https://github.com/tricktresor/alv-grid-merge-cells

I just ADDED without any problem the 5 method of ZTRCKTRSR_GUI_ALV_GRID_MERGE to ZCL_FAVL

Z_DISPLAY Instance Method Public
Z_INIT_CELL_STYLES Instance Method Public
Z_SET_CELL_STYLE Instance Method Public
Z_SET_FIXED_COL_ROW Instance Method Public
Z_SET_MERGE_HORIZ Instance Method Public
Z_SET_MERGE_VERT Instance Method Public

@fidley
Copy link
Owner

fidley commented Aug 6, 2023

Hi @RTagliento,
I looked on this PR and for me it is reasonable to rewrite the code a bit, to not have two different display methods. I'll try to make it this week.
Cheers
Łukasz

@RTagliento
Copy link
Contributor Author

That sound great and good ... I am Happy.

Thank you.

@SantiMorenoSAP
Copy link

SantiMorenoSAP commented Aug 6, 2023 via email

@fidley
Copy link
Owner

fidley commented Aug 14, 2023

#79 I've added the code in a bit different way. All method are without Z_* prefix, Z_DISPLAY is called redraw_after_merging_change and it's called automatically one time, when you adapt the merging on the cell in the new FALV event BEFORE_FIRST_DISPLAY. The handler for this event is added and can be redefined like in the ZDEMO_FALV27 program, could you please check it @RTagliento ?

@RTagliento
Copy link
Contributor Author

Great!

Tomorrow I will use soon this new version! 😄

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RTagliento
Copy link
Contributor Author

It is working and I am in progress.... thank you a lot!

horizontal merge works.....

next step vertical merge and DROPDOWN

image

@fidley
Copy link
Owner

fidley commented Aug 15, 2023

Looks like an Excel file 😁

@RTagliento
Copy link
Contributor Author

vertical merge is ok.... dropdown too ;)

image

@fidley
Copy link
Owner

fidley commented Aug 16, 2023

Perfect, thanks a lot!

@RTagliento
Copy link
Contributor Author

Hi Łukasz,
extra question/opinion.

I know that into ALV cell we cannot have wrapped words. Do you confirm?

I resolved doing this:
image

but as you can see.... that are 2 cells and not one merged as the others.

@fidley
Copy link
Owner

fidley commented Aug 20, 2023

As far as I know, word wrap is not allowed in grid cells. I've never seen it and never seen the variables or methods that would allow that in ALV Grid or Tree.

@RTagliento
Copy link
Contributor Author

Thanks about this confirmation. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants