Micro optimisation: calls to String.replaceAll need to be replaced

[01es]

Description

String.replaceAll is implemented using regular expression with a pattern compiled upon each call. Matching even short strings is computationally expensive. In TG we have multiple places where String.replaceAll is used extensively and some places where it is used accidentally, and String.replace would suffice.

Performance of String.replace is much better as it does not support regular expression. However, under Java8 it still performs worse than alternative StringUtils.replace() from Apache Commons Lang, which has optimisation for strings with no matches. Starting with Java9, the performance for String.replace is equivalent to StringUtils.replace().

Therefore, the main objective of this issue is to inspect all calls to String.replaceAll and improve them.

• Replace calls to String.replaceAll to String.replace where no regular expression matching is necessary, and with StringUtils.remove where replacement is with an empty string.

• Replace calls to String.replaceAll where regular expression is needed by using a precompiled pattern where possible. RegExUtils could be conveniently used for this purpose.

- [ ] Consider replacing String.split with Guava Splitter for optimal performance. -- String.split turned out to be more efficient.

Expected outcome

Improved performance.