This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
Add basic support for colspan in data cells #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows data cells to have colspans, however a data cell can not span multiple header columns.
|
@zachleat - can you give this a look next week? |
|
@jgibson Thank you: this works great! And in so little code too! Really great work |
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the toggling algorithm doesn't take into account colspans in cells within the data. This behavior leads to toggling of incorrect columns when dealing with both wide headers and wide data.
This PR corrects that issue for the simple case where data can have a colspan that is not larger than its corresponding header nor does it cross any logical column boundaries.
Note that I wasn't sure if I should update the dist directory or not, so I left it unchanged. I can update if that's the appropriate workflow for this project.