Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Collapsible groups #2214

Merged
merged 1 commit into from
Apr 24, 2022
Merged

fix: Collapsible groups #2214

merged 1 commit into from
Apr 24, 2022

Conversation

danharrin
Copy link
Member

Fixes #2023.

@danharrin danharrin added bug Something isn't working ui labels Apr 24, 2022
@danharrin danharrin merged commit b0e7e37 into 2.x Apr 24, 2022
@danharrin danharrin mentioned this pull request Apr 24, 2022
Closed
@danharrin danharrin deleted the fix/collapsible-groups-in-non-collapsible-sidebar branch April 24, 2022 11:06
@danharrin danharrin mentioned this pull request Apr 24, 2022
Closed
@pxlrbt
Copy link
Member

pxlrbt commented Apr 24, 2022

@danharrin I think this removes the feature of auto-collapsing the nav groups when collapsing the sidebar. Any ideas how we could archive both?

@danharrin
Copy link
Member Author

Pretty sure I accounted for that, have you tested?

@pxlrbt
Copy link
Member

pxlrbt commented Apr 24, 2022

Sorry, didn't see your change in group.blade.php and thought it was only formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidebar groups cannot be collapsed when collapsible sidebar is off
2 participants
@danharrin @pxlrbt