Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues #2522: Only a section of items being returned in a directory. #2571

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

ArthurMousatov
Copy link
Contributor

Description

This is a quick fix for issue #2522. From what I've seen, the issue seems to happen at Listing.vue:colunmsResize:614:

  1. As the css() call may return null, items becomes null and as a result, causes an exception.
  2. This exceptions stops the creation of the window listeners in the mounted() function.
  3. Since there is no scroll event expanding the items on the page, only the initial amount of items is shown.

A quick return on items being null seems to fix the issue.

🚨 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

Further comments

@o1egl o1egl merged commit 2744f7d into filebrowser:master Jul 27, 2023
7 of 8 checks passed
langren1353 pushed a commit to langren1353/filebrowser-player that referenced this pull request Jul 31, 2023
langren1353 pushed a commit to langren1353/filebrowser-player that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants