Skip to content

Conversation

similicious
Copy link
Contributor

@similicious similicious commented Feb 15, 2025

Description
fixes #3721

Sets the code argument of addLanguage to a proper IANA language code instead of the static string videoPlayerLocal. See videojs docs.

This fixes the exception reported in #3721 causing the video controls to not show.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • AVOID breaking the continuous integration build.

@similicious similicious marked this pull request as ready for review February 15, 2025 22:13
@similicious similicious requested a review from o1egl as a code owner February 15, 2025 22:13
shengj1ang added a commit to shengj1ang/filebrowser that referenced this pull request Feb 24, 2025
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 19, 2025
@giulianozor
Copy link

giulianozor commented Apr 19, 2025

Any ETÀ for merging this ?

@github-actions github-actions bot removed the Stale label Apr 20, 2025
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 20, 2025
@giulianozor
Copy link

Is this project still maintained?

@github-actions github-actions bot removed the Stale label May 22, 2025
@o1egl o1egl merged commit 71a8f56 into filebrowser:master Jun 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Video controls on iPadOS mobile Safari
3 participants