Add tipset weight tiebreak rule FIP #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
dignifiedquire,
jennijuju,
momack2 and
whyrusleeping
as code owners
This was referenced Sep 7, 2021
arajasek
force-pushed
the
asr/weight
branch
from
84546c4
to
f2c1be9
Compare
ZenGround0
approved these changes
Sep 21, 2021
_fips/fip_weight_tie.md
Outdated
| ## Specification | ||
| <!--The technical specification should describe the syntax and semantics of any new feature. The specification should be detailed enough to allow competing, interoperable implementations for any of the current Filecoin implementations. --> | ||
|
|
||
| For two tipsets with the same weight and the same number of blocks, we pick the tipset with the smallest winning Ticket. In the case where two Tipsets of equal weight have the same smallest Ticket, we compare the next smallest Ticket in the Tipset (and select the Tipset with the smaller one). This continues until one Tipset is selected. |
There was a problem hiding this comment.
It's not a rational strategy but I think a block producer willing to get slashed can create a tie. So it's worth specifying what we do in that case even just saying its undefined.
There was a problem hiding this comment.
Ack, gonna say it's explicitly undefined
| This FIP proposes a "soft" change that maintains full backward compatability. No new network version is needed. | ||
|
|
||
| ## Test Cases | ||
| <!--Test cases for an implementation are mandatory for FIPs that are affecting consensus changes. Other FIPs can choose to include links to test cases if applicable.--> |
There was a problem hiding this comment.
- two tipsets with different min tickets
- two tipsets with one min ticket the same
- two tipsets with several min tickets the same
- three heaviest heads
- two tipsets with all min tickets the same (unless you leave it undefined then test doesn't make much sense)
There was a problem hiding this comment.
Added, thank you!
_fips/fip_weight_tie.md
Outdated
| ## Product Considerations | ||
| <!--All FIPs must contain a section that discusses the product implications/considerations relative to the proposed change. Include information that might be important for product discussion. A discussion on how the proposed change will enable better storage-related goods and services to be developed on Filecoin. FIP submissions missing the "Product Considerations" section will be rejected. An FIP cannot proceed to status "Final" without a Product Considerations discussion deemed sufficient by the reviewers.--> | ||
|
|
||
| No change to product considerations. |
There was a problem hiding this comment.
Network more stable in extreme conditions is one possible plus.
There was a problem hiding this comment.
Added, thank you!
| ## Simple Summary | ||
| <!--"If you can't explain it simply, you don't understand it well enough." Provide a simplified and layman-accessible explanation of the FIP.--> | ||
|
|
||
| It is not an unlikely event for two tipsets to have the same weight. When this happens, we should have a simple rule to pick one of the tipsets as canonically "heavier" so as to achieve consensus faster. This FIP proposes such a rule. |
There was a problem hiding this comment.
It would help to give background by linking to the spec. I forget what the exact weight function is so I'm guessing lots of other people do to.
arajasek
force-pushed
the
asr/weight
branch
from
f2c1be9
to
1dd0e5a
Compare
jennijuju
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #22