FIP-0086: Specify power table scaling & comm tree #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've left the PowerTable directly in the struct for convenience. It also means we can reduce scope and punt the commitment tree specifics into the future. I've also: 1. Redefined the Tipset as a list of CIDs. 2. Clarified that the power table is a bare CBOR list (no wrapping structure).
This patch specifies the power table scaling discussed in our standups, scaling power between zero and 0xFFFF. I've also been careful to specify the correct inequalities and rounding. Honestly, all this would be better specified as pseudo-Python.
Stebalien
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
anorth,
raulk,
jsoares and
TippyFlitsUK
as code owners
Stebalien
commented
Apr 4, 2024
| @@ -270,17 +270,16 @@ type Payload struct { | |||
| } | |||
|
|
|||
| type ECTipset struct { | |||
| Epoch int | |||
| Epoch uint64 | |||
kaitlin-beegle
approved these changes
Apr 4, 2024
anorth
approved these changes
Apr 4, 2024
jsoares
changed the title
jsoares
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch specifies the power table scaling discussed in our standups, scaling power between zero and 0xFFFF. I've also been careful to specify the correct inequalities and rounding.
(honestly, all this would be better specified as pseudo-python)