Update to FVM SDK 3.0.0-alpha.22, shared 3.0.0-alpha.17, ipld_encoding 0.3.3 #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
asr/update-fvm
branch
from
e1f3756
to
6af6d3f
Compare
arajasek
commented
Jan 24, 2023
actors/datacap/src/lib.rs
Outdated
| self.rt.message().receiver().id().unwrap() | ||
| } | ||
|
|
||
| // TODO: What's the best way to avoid this duplication? |
There was a problem hiding this comment.
The solution now looks good, please remove this comment.
arajasek
force-pushed
the
asr/update-fvm
branch
from
6af6d3f
to
095adb1
Compare
arajasek
commented
Jan 24, 2023
| && expected_msg.params == params | ||
| && expected_msg.value == value, | ||
| ); | ||
| assert_eq!(expected_msg.to, *to); |
There was a problem hiding this comment.
Makes debugging failures easier.
arajasek
force-pushed
the
asr/update-fvm
branch
from
095adb1
to
f8e2062
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1095 +/- ##
==========================================
- Coverage 89.34% 89.17% -0.18%
==========================================
Files 93 93
Lines 19613 19637 +24
==========================================
- Hits 17524 17511 -13
- Misses 2089 2126 +37
|
arajasek
force-pushed
the
asr/update-fvm
branch
from
f8e2062
to
0b87dbd
Compare
arajasek
force-pushed
the
asr/update-fvm
branch
from
0b87dbd
to
4ab4967
Compare
anorth
reviewed
Jan 24, 2023
|
|
||
| fn set_state_root(&mut self, root: &Cid) -> Result<(), ActorError> { | ||
| Ok(fvm::sself::set_root(root)?) | ||
| } |
There was a problem hiding this comment.
Ok if we're going to need these for the EVM actor, otherwise would prefer not to add them.
|
Looks good after we resolve the token library syscall thing |
arajasek
force-pushed
the
asr/update-fvm
branch
from
7045dc3
to
7f13c4c
Compare
anorth
reviewed
Jan 24, 2023
actors/datacap/src/lib.rs
Outdated
| let msg = Messenger { rt }; | ||
| let intermediate = hook.call(&&msg).actor_result()?; | ||
| let msg = SyscallProvider { rt }; | ||
| let intermediate = hook.call(as_token(&mut st, &msg).runtime()).actor_result()?; |
There was a problem hiding this comment.
This is even more funky now as there's no logical need for the state to be involved in getting a runtime abstraction. You actually just need an ActorRuntime, as constructed in as_token. Copy just that bit of construction here?
anorth
approved these changes
Jan 24, 2023
actors/datacap/src/lib.rs
Outdated
| self.rt.message().receiver().id().unwrap() | ||
| } | ||
|
|
||
| // TODO: What's the best way to avoid this duplication? |
There was a problem hiding this comment.
The solution now looks good, please remove this comment.
arajasek
force-pushed
the
asr/update-fvm
branch
from
7f13c4c
to
0d13662
Compare
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Jan 31, 2023
…g 0.3.3 (filecoin-project#1095) * Update to FVM SDK 3.0.0-alpha.22, shared 3.0.0-alpha.17, ipld_encoding 0.3.3 * Datacap: Turn Messenger struct into SyscallProvider * Update frc42_dispatch, frc46_tokn, fvm_actor_utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-factor that updates this repo to rely on FVM3 deps, without introducing or supporting any FEVM functionality. The new crates themselves do include some FEVM changes:
Most of the changes here result from integrating the latest changes in the https://github.com/helix-onchain/filecoin repo.
Needs: