Runtime: Add several new methods #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
approved these changes
Feb 2, 2023
runtime/src/runtime/mod.rs
Outdated
| /// The gas still available for computation | ||
| fn gas_available(&self) -> u64; | ||
|
|
||
| /// The current tipset's timestamp, as UNIX seconds |
There was a problem hiding this comment.
Could you clarify whether "current" is the tipset that includes the message, or the subsequent one when the message is executed?
runtime/src/runtime/mod.rs
Outdated
| fn tipset_timestamp(&self) -> u64; | ||
|
|
||
| /// The hash of on of the last 256 blocks | ||
| fn tipset_cid(&self, epoch: i64) -> Option<Cid>; |
There was a problem hiding this comment.
What happens if epoch is more than 256 ago? Just None? Kinda wierd we don't get error numbers here.
There was a problem hiding this comment.
I agree -- I think a Result would make more sense here. I've raised it here.
Also the comment on this is wrong (AFAIC tell) -- you can lookup Finality epochs. I'm going to update it.
There was a problem hiding this comment.
Thanks, yes I would expect FINALITY too
This was referenced Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from
next.This PR adds the following methods to the Runtime interface:
actor_balancegas_availabletipset_timestamptipset_cidhashhash_64recover_secp_public_keyNote: This isn't the most cohesive PR, sorry :')