Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plausible module #132

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: plausible module #132

wants to merge 7 commits into from

Conversation

tikagan
Copy link
Collaborator

@tikagan tikagan commented Jan 29, 2024

  • plausible middleware refactored into module
  • plausible module optionally fires in non-production mode if local tracking explicitly enabled in nuxt.config

@tikagan tikagan self-assigned this Jan 29, 2024
@tikagan tikagan requested a review from orvn January 30, 2024 17:43
Copy link
Collaborator

@orvn orvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tikagan can you remind me why we added the module files directly to the repo instead of including it as a dependency?

@tikagan
Copy link
Collaborator Author

tikagan commented Feb 14, 2024

@orvn two reasons:

  1. we haven't packaged this up and made it an npm module yet
  2. this version of the module is for Nuxt 2 and the version we're planning on packaging up for npm is for Nuxt 3 (I did look into it but there's no way to write the module so it's compatible with both)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants