Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

Update go-address for latest SubnetID version #221

Merged
merged 9 commits into from
Jul 12, 2022
Merged

Conversation

adlrocha
Copy link
Collaborator

Fixes #220

@adlrocha
Copy link
Collaborator Author

adlrocha commented Jul 11, 2022

@dnkolegov, I am running out of battery in the airport, if you don't mind having a look at the linter errors I'd appreciate it. If you don't have time no worries, I'll check them out when I land. Thanks 🙏

Copy link
Collaborator

@dnkolegov dnkolegov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just several questions about ignoring returned errors and logging messages.

chain/consensus/common/cns_validations.go Outdated Show resolved Hide resolved
chain/consensus/common/cns_validations.go Outdated Show resolved Hide resolved
chain/consensus/delegcns/delegated.go Show resolved Hide resolved
chain/consensus/hierarchical/actors/sca/sca_actor.go Outdated Show resolved Hide resolved
chain/consensus/hierarchical/actors/sca/sca_cross.go Outdated Show resolved Hide resolved
chain/consensus/hierarchical/actors/sca/sca_state.go Outdated Show resolved Hide resolved
@adlrocha adlrocha merged commit 5f1fba4 into eudico Jul 12, 2022
@adlrocha adlrocha deleted the update/go-address branch July 12, 2022 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest version of go-address
2 participants