Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Cid.Equals() #110

Closed
wants to merge 3 commits into from
Closed

fix: use Cid.Equals() #110

wants to merge 3 commits into from

Conversation

birdychang
Copy link
Contributor

No description provided.

@Stebalien
Copy link
Member

This isn't necessary. Honestly, we should just deprecate that method.

Context: that method exists from ancient times when CIDs weren't comparable with ==. But we fixed that long ago by changing the internal representation of a cid.Cid to string so we could, e.g., use them in maps.

@Stebalien Stebalien mentioned this pull request May 12, 2023
Closed
@birdychang birdychang closed this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birdychang @Stebalien