Message ID can be int, string, or null as per OpenRPC spec

[rvagg]

Fixes: #28

[mvdan]

You could add a sanity check here that "actual" is one of the three allowed Go types, just as an extra sanity check since UarshalJSON does it too.

[rvagg]

thanks @mvdan, added and it picked up a bug in my code! can you sanity check my latest commit to see if it's how you would have done it?

[mvdan]

SGTM. You could simplify it a little bit, since you don't need to separate the json.Marshal calls:

	switch r.actual.(type) {
	case nil, int64, string:
		return json.Marshal(r.actual)
	default:
		return nil, fmt.Errorf("unexpected ID type: %T", r.actual)
	}

[rvagg]

👍 thanks & done

[rvagg]

Updated so all the map[uint64]s are map[interface{}] in websockets.go now, I'd left out chanHandlers. I think this is safe because it's per-client so it's therefore up to the client to get the IDs sorted out properly. A test for this via websockets might be nice but I suspect that'd be an enormous amount of work just to test strings.

[rvagg]

@magik6k any chance of getting some eyes on this? I know it's not a trivial change but it'd be nice to be able to support OpenRPC properly.