Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Server header with version #370

Merged
merged 1 commit into from
Aug 4, 2023
Merged

feat: add Server header with version #370

merged 1 commit into from
Aug 4, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 3, 2023

@rvagg rvagg requested a review from hannahhoward August 3, 2023 23:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #370 (e4451a9) into main (a00bdcb) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   77.58%   77.68%   +0.09%     
==========================================
  Files          86       86              
  Lines        6402     6403       +1     
==========================================
+ Hits         4967     4974       +7     
+ Misses       1183     1178       -5     
+ Partials      252      251       -1     
Files Changed Coverage Δ
pkg/server/http/ipfs.go 88.02% <100.00%> (+1.63%) ⬆️

... and 6 files with indirect coverage changes

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg rvagg merged commit f693649 into main Aug 4, 2023
16 checks passed
@rvagg rvagg deleted the rvagg/server-version branch August 4, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include lassie version in daemon response header
3 participants