fix: add protocol detail to more events for better logging #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 77.49% 77.59% +0.10%
==========================================
Files 86 86
Lines 6403 6423 +20
==========================================
+ Hits 4962 4984 +22
- Misses 1186 1188 +2
+ Partials 255 251 -4
|
willscott
approved these changes
Aug 9, 2023
hannahhoward
approved these changes
Aug 9, 2023
Primarily for use with the CLI so you can see "Bitswap" where appropriate. events.Identifier() uses an interface check to get the SP ID and returns "" if the event doesn't have one and if it doesn't have a protocol; this means it returns "" for a lot of events where there could be a "Bitswap".
rvagg
force-pushed
the
rvagg/event-logging-detail
branch
from
91abb8c
to
28fcac9
Compare
Gate the case where the retriever (parent) cancels a protocol retriever because another has completed successfully. If a retrieval fails in this case, it's not a failure that we should either report in the event system, or record against the SP's performance stats. Fixes: #364 I believe this fixes #364, but it's hard to reproduce reliably so I can't be sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily for use with the CLI so you can see "Bitswap" where appropriate. events.Identifier() uses an interface check to get the SP ID and returns "" if the event doesn't have one and if it doesn't have a protocol; this means it returns "" for a lot of events where there could be a "Bitswap".