eth_getLogs produces lots of WARN log output for non-FEVM events

[rvagg]

This bit of code worked fine when there were only FEVM events:

lotus/node/impl/full/eth_events.go

Lines 43 to 84 in bfb3602

	if entry.Codec != cid.Raw {
	log.Warnw("did not expect an event entry with a non-raw codec", "codec", entry.Codec, "key", entry.Key)
	return nil, nil, false
	}
	// Check if the key is t1..t4
	if len(entry.Key) == 2 && "t1" <= entry.Key && entry.Key <= "t4" {
	// '1' - '1' == 0, etc.
	idx := int(entry.Key[1] - '1')
	// Drop events with mis-sized topics.
	if len(entry.Value) != 32 {
	log.Warnw("got an EVM event topic with an invalid size", "key", entry.Key, "size", len(entry.Value))
	return nil, nil, false
	}
	// Drop events with duplicate topics.
	if topicsFound[idx] {
	log.Warnw("got a duplicate EVM event topic", "key", entry.Key)
	return nil, nil, false
	}
	topicsFound[idx] = true
	topicsFoundCount++
	// Extend the topics array
	for len(topics) <= idx {
	topics = append(topics, ethtypes.EthHash{})
	}
	copy(topics[idx][:], entry.Value)
	} else if entry.Key == "d" {
	// Drop events with duplicate data fields.
	if dataFound {
	log.Warnw("got duplicate EVM event data")
	return nil, nil, false
	}
	dataFound = true
	data = entry.Value
	} else {
	// Skip entries we don't understand (makes it easier to extend things).
	// But we warn for now because we don't expect them.
	log.Warnw("unexpected event entry", "key", entry.Key)
	}

But post nv22, anyone not filtering events down to specifically FEVM events, such as block explorers or anyone else capturing general logs, will trigger a lot of logs because our builtin actor events don't match these criteria, starting with the Codec not being Raw.

{"level":"warn","ts":"2024-03-14T11:08:41.661+1100","logger":"fullnode","caller":"full/eth_events.go:44","msg":"did not expect an event entry with a non-raw codec","codec":81,"key":"$type"}
{"level":"warn","ts":"2024-03-14T11:08:41.661+1100","logger":"fullnode","caller":"full/eth_events.go:44","msg":"did not expect an event entry with a non-raw codec","codec":81,"key":"$type"}
{"level":"warn","ts":"2024-03-14T11:08:41.661+1100","logger":"fullnode","caller":"full/eth_events.go:44","msg":"did not expect an event entry with a non-raw codec","codec":81,"key":"$type"}
{"level":"warn","ts":"2024-03-14T11:08:41.661+1100","logger":"fullnode","caller":"full/eth_events.go:44","msg":"did not expect an event entry with a non-raw codec","codec":81,"key":"$type"}
{"level":"warn","ts":"2024-03-14T11:08:41.661+1100","logger":"fullnode","caller":"full/eth_events.go:44","msg":"did not expect an event entry with a non-raw codec","codec":81,"key":"$type"}
{"level":"warn","ts":"2024-03-14T11:08:41.661+1100","logger":"fullnode","caller":"full/eth_events.go:44","msg":"did not expect an event entry with a non-raw codec","codec":81,"key":"$type"}

I think that we probably don't need to log these at all, or just drop down to DEBUG.