docs:Building_a_network_skeleton.md cleanups #12079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks have passed |
BigLep
changed the title
Go-State-Types Checklist updates
…ead of 3 or more "x"'s in some cases. Adjusted ToC.
Go-State-Types Checklist updates
…ead of 3 or more "x"'s in some cases. Adjusted ToC.
Go-State-Types Checklist updates
…ead of 3 or more "x"'s in some cases. Adjusted ToC.
rjan90
force-pushed
the
biglep/202406-network-skeleton-docs-update
branch
from
e97641c
to
35b0155
Compare
rjan90
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
I rebased the PR on master to include only the actual diff in this PR, excluding all other merge commits. Hope that's okay!
The changes looks good to me, and I like the simplification in the step where you need to change all references from vX to v(X+1) in Go-State-Types! Merge at will.
Doh - yes - thanks for fixing. My bad. I should have caught that. My git foo is rusty. I was trying to do this in VS Code. I'll sync up with you offline in the way you do this so I don't repeat that mistake. Thanks again for the help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Making some updates/changes while reading through Building_a_network_skeleton.md
Additional Info
Go-State-Types Checklist updates
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, depsIf the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.New features have usage guidelines and / or documentation updates inLotus DocumentationDiscussion TutorialsTests exist for new functionality or change in behavior