fix: Eth Tx Events Bloom Filter: fix slice modification bug and flaky test #12203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarshkshah1992
changed the title
rvagg
reviewed
Jul 10, 2024
rvagg
reviewed
Jul 10, 2024
rvagg
approved these changes
Jul 10, 2024
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Jul 17, 2024
… test (filecoin-project#12203) * fix the event bloom filter in eth tx receipts
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Jul 24, 2024
… test (filecoin-project#12203) * fix the event bloom filter in eth tx receipts
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 17, 2024
… test (filecoin-project#12203) * fix the event bloom filter in eth tx receipts
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 20, 2024
… test (filecoin-project#12203) * fix the event bloom filter in eth tx receipts
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 20, 2024
… test (filecoin-project#12203) * fix the event bloom filter in eth tx receipts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the Bloom Filter for events that is part of ETH Tx receipts. The issue is that all receipts reference the same underlying backing empty array for it's events bloom filter during initialisation. However, modification to the bloom filter then also modifies the backing array... which is then used to initialise other bloom filters.
This also fixes the eth_filters flaky itest.