misc: add waffle to match w/ forest #12247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennijuju
added
the
skip/changelog
rvagg
reviewed
Jul 17, 2024
rvagg
approved these changes
Jul 17, 2024
aarshkshah1992
approved these changes
Jul 17, 2024
|
@rvagg @aarshkshah1992 you guys are 🆒 |
jennijuju
added a commit
that referenced
this pull request
Jul 17, 2024
add waffle splash for the nv23 upgrade to match w/ forest
ribasushi
reviewed
Jul 17, 2024
| @@ -2520,6 +2518,7 @@ func UpgradeActorsV14(ctx context.Context, sm *stmgr.StateManager, cache stmgr.M | |||
| if err != nil { | |||
| return cid.Undef, xerrors.Errorf("migrating actors v14 state: %w", err) | |||
| } | |||
| fmt.Print(upgradeSplash) | |||
There was a problem hiding this comment.
@rvagg @jennijuju it'd be more friendly to guard this print to STDOUT with a TTY check. If the check returns false - this means the log is being redirected to a file, and someone will be potentially parsing it. The ascii art could break their observability in the most critical moment.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forest has this & it's pretty sweet 😄 can we have the same too?
