Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polish(chainwatch): accept lotus api and token #3337

Merged
merged 1 commit into from
Aug 27, 2020
Merged

polish(chainwatch): accept lotus api and token #3337

merged 1 commit into from
Aug 27, 2020

Conversation

frrist
Copy link
Member

@frrist frrist commented Aug 27, 2020 •
edited by placer14
Loading

Completes filecoin-project/sentinel#47. Will leave draft once manually validated.

placer14
placer14 suggested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two changes needed.

cmd/lotus-chainwatch/main.go Show resolved Hide resolved
cmd/lotus-chainwatch/util/api.go Outdated Show resolved Hide resolved
@frrist frrist force-pushed the feat/chainwatch/lotus-tokens branch 2 times, most recently from b21d7b6 to 1c64f1d Compare August 27, 2020 19:17
@frrist frrist requested a review from placer14 August 27, 2020 19:17
@frrist frrist marked this pull request as ready for review August 27, 2020 19:17
@frrist frrist force-pushed the feat/chainwatch/lotus-tokens branch from 1c64f1d to 5c4db23 Compare August 27, 2020 21:05
placer14
placer14 approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM 🤝

@magik6k magik6k merged commit 5aa90b0 into master Aug 27, 2020
@magik6k magik6k deleted the feat/chainwatch/lotus-tokens branch August 27, 2020 22:27
@placer14 placer14 mentioned this pull request Aug 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placer14 placer14 placer14 approved these changes

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frrist @placer14 @magik6k