Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(market): update state diffing for market actor #3889

Merged

Conversation

hannahhoward
Copy link
Contributor

Goals

Complete changes to make state predicates work for abstract types on markets

Implementation

  • Move the ADT diffing functions inside of the chain/actors/adt package (especially since they are abstract functions for diffing ADTs)
  • Build out the abstract storage market actor to support state diffing
  • Specifically leaving unaddressed for the most part how to compare states across versions -- need to get a sense of what could change first. Presumably every comparison would be a different case on a version by version basis... unfortunately. And would need to be handled inside the actors package.
  • If this pattern works it can be applied to the miner diffing functions as well.

Update to abstract actor for markets state diffing. Also move the diff adt functions inside the
abstract actors
@arajasek
Copy link
Contributor

I want this, so I'm merging it :D

@arajasek arajasek merged commit 81004ea into refactor/net-upgrade Sep 17, 2020
@arajasek arajasek deleted the refactor/net-upgrade-markets-deal-states branch September 17, 2020 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants