adding in ledger support #4290
Merged
adding in ledger support #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Oct 10, 2020
chain/messagepool/messagepool.go
Outdated
Comment on lines
1252
to
1253
| return nil | ||
| // TODO: this causes super slow startup... |
There was a problem hiding this comment.
TODO: Remove before merge (Tho I guess we can also fix this while here)
magik6k
force-pushed
the
feat/ledger-integration
branch
2 times, most recently
from
546f1f5
to
de59d08
Compare
Kubuxu
reviewed
Oct 10, 2020
Kubuxu
reviewed
Oct 10, 2020
chain/wallet/multi.go
Outdated
| } | ||
|
|
||
| func (m MultiWallet) WalletImport(ctx context.Context, info *types.KeyInfo) (address.Address, error) { | ||
| w := firstNonNil(m.Remote, m.Ledger, m.Local) |
There was a problem hiding this comment.
This means that you cannot import to a normal key if you have a ledger, or ledger key if you have Remote (the latter I think might be fine).
Probably the solution is to make the Ledger key be different type of key.
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Kubuxu
force-pushed
the
feat/ledger-integration
branch
from
644c914
to
2b21fde
Compare
added 3 commits
October 12, 2020 00:48
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
magik6k
approved these changes
Oct 12, 2020
Kubuxu
approved these changes
Oct 12, 2020
|
It would be great to write some docs on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some work to do here, but this does work!
Basic instructions:
First build lotus-wallet (patched to use the ledger wallet code), configure your lotus daemon to use it, and run it.
Then,
put the last line of that output into a file,
ledgerkey.jsonor somethingStart
lotus-wallet:Setup config in lotus for remove wallet:
$LOTUS_PATH/config.toml:Import the key info into the wallet:
Now the key should show up in
lotus wallet listIf you try to sign anything with the key, for example:
It will prompt you to approve the transaction on your ledger, blocking until you approve it.