Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: Add CID fields to messages in json marshalers #4338

Merged
merged 2 commits into from
Oct 13, 2020
Merged

types: Add CID fields to messages in json marshalers #4338

merged 2 commits into from
Oct 13, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 12, 2020

Fixes #4335

@magik6k magik6k requested a review from arajasek October 12, 2020 18:47
whyrusleeping
whyrusleeping approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful.

@Kubuxu Kubuxu merged commit 5fd0bf1 into master Oct 13, 2020
@Kubuxu Kubuxu deleted the feat/message-json-cids branch October 13, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

@arajasek arajasek Awaiting requested review from arajasek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return CID in MpoolPushMessage
3 participants
@magik6k @whyrusleeping @Kubuxu