Remove most v0 actor imports #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested review from
Kubuxu,
magik6k,
raulk and
whyrusleeping
as code owners
Stebalien
force-pushed
the
steb/actor-v2-imports
branch
from
6a387e1
to
fd6c5a5
Compare
Stebalien
force-pushed
the
steb/actor-v2-imports
branch
3 times, most recently
from
ab580ad
to
99c6e95
Compare
Method numbers never change anyways. At worst, we'll deprecate old methods and have to explicitly import them from the correct actors version to use them.
1. Version 0 upgrades happen _after_ genesis. 2. Get rid of UseNewestNetwork. It's not useful and quite dangerous.
It doesn't matter now, but may in the future.
We're still on actors v0 in this test.
Stebalien
force-pushed
the
steb/actor-v2-imports
branch
from
99c6e95
to
5e23933
Compare
magik6k
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set removes most actors v0 imports. It also aliases method numbers into the actor abstractions because these must not change between releases (at most, they can be "deprecated").