Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client deal: Cache CommD when creating multiple deals #4535

Merged
merged 2 commits into from
Oct 27, 2020
Merged

client deal: Cache CommD when creating multiple deals #4535

merged 2 commits into from
Oct 27, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 22, 2020

No description provided.

whyrusleeping
whyrusleeping approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM if you tell me that we copied this commPwriter code from somewhere else. If we didnt, then it should probably get more review. In any case, that seems like it should live in a lib or something

@magik6k magik6k merged commit 8c60069 into master Oct 27, 2020
@magik6k magik6k deleted the feat/clientdeal-cache-commd branch October 27, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @whyrusleeping