Make wallet market withdraw usable with miner addresses #4556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/wallet.go
Outdated
| @@ -495,6 +495,11 @@ var walletMarketWithdraw = &cli.Command{ | |||
| Usage: "Specify address to withdraw funds from, otherwise it will use the default wallet address", | |||
| Aliases: []string{"f"}, | |||
| }, | |||
| &cli.StringFlag{ | |||
| Name: "address", | |||
| Usage: "Market address to withdraw from (account or miner actor address)", | |||
There was a problem hiding this comment.
maybe say "defaults to the from address if unset" ?
whyrusleeping
approved these changes
Oct 23, 2020
magik6k
force-pushed
the
fix/marketwithdraw-miner
branch
from
4f10e14
to
b7b6ab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.