Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random test failures #4559

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Fix random test failures #4559

merged 1 commit into from
Oct 23, 2020

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Oct 23, 2020

If block 1 was a null block then blockSet would include genesis which
would lead to us trying to load parent of a genesis block.

Resolves #4317

If block 1 was a null block then blockSet would include genesis which
would lead to us trying to load parent of a genesis block.

Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
@Kubuxu Kubuxu added impact/test-flakiness Impact: Test Flakiness kind/test Kind: Test labels Oct 23, 2020
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@magik6k magik6k merged commit 8124fe9 into master Oct 23, 2020
@magik6k magik6k deleted the fix/beyond-genesis branch October 23, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/test-flakiness Impact: Test Flakiness kind/test Kind: Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random test failure, syncing beyond genesis
3 participants