Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shed: Util for creating ID CIDs #4726

Merged
merged 1 commit into from
Nov 6, 2020
Merged

shed: Util for creating ID CIDs #4726

merged 1 commit into from
Nov 6, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 4, 2020

No description provided.

return fmt.Errorf("must specify data")
}

dec, err := hex.DecodeString(cctx.Args().First())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically you can have a string be valid in both hex and base64, can't you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highly unlikely unless you specifically craft one


var cidIdCmd = &cli.Command{
Name: "id",
Usage: "create identitg CID from hex or base64 data",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/identitg/identity/

@magik6k magik6k merged commit 2f9d19c into master Nov 6, 2020
@magik6k magik6k deleted the feat/shed-id-cid branch November 6, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants