Add a command to get the fees of a deal #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
reviewed
Jan 8, 2021
cli/state.go
Outdated
| } | ||
|
|
||
| var stateGetDealSetCmd = &cli.Command{ | ||
| Name: "get-deal", |
There was a problem hiding this comment.
state deal get-deal? I'd make it just state deal get.
There was a problem hiding this comment.
yeah, that's better
cli/state.go
Outdated
| } | ||
|
|
||
| var stateDealFeesCmd = &cli.Command{ | ||
| Name: "get-fees", |
cli/state.go
Outdated
| ht = ts.Height() | ||
| } | ||
|
|
||
| if pdrStr := cctx.String("provider"); pdrStr != "" { |
There was a problem hiding this comment.
Suggested change
| if pdrStr := cctx.String("provider"); pdrStr != "" { | |
| if cctx.IsSet("provider") { |
arajasek
force-pushed
the
asr/deal-dues
branch
from
deee192
to
5a6d07e
Compare
Kubuxu
reviewed
Jan 13, 2021
cli/state.go
Outdated
| Flags: []cli.Flag{ | ||
| &cli.StringFlag{ | ||
| Name: "provider", | ||
| Usage: "provider whose outstanding fees you'd like to recover", |
There was a problem hiding this comment.
changed to calculate
There was a problem hiding this comment.
@Kubuxu this looks good to you now?
arajasek
force-pushed
the
asr/deal-dues
branch
from
5a6d07e
to
b3d6396
Compare
magik6k
reviewed
Mar 2, 2021
cli/state.go
Outdated
| return fmt.Errorf("failed to parse provider: %w", err) | ||
| } | ||
|
|
||
| deals, err := api.StateMarketDeals(ctx, ts.Key()) |
There was a problem hiding this comment.
I'd avoid this API call, it will return all the milions of deals in the market actor, calling it with curl the response is 366M and takes 1.5min
|
Discussion summary: Make this a shed command (since it's gonna be slooowww). The CLI command itself should be better, perhaps using markets info as source of truth. |
|
Now just a shed command |
magik6k
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5294