Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StateManager.Replay on reward actor #5804

Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix: StateManager.Replay on reward actor #5804

merged 1 commit into from
Mar 25, 2021

Conversation

zl03jsj
Copy link
Contributor

@zl03jsj zl03jsj commented Mar 12, 2021

in the statemanager.replay method,
after get the msg(specified by 'mcid' param) execution result,
the callback function returns an 'errHaltExecution' to break out the loop in computeTipSetState
but some times computeTipsetstate warps the errHaltExecution with xerrors
that would cause following expression:

(err != errHaltExecution) to be true .

which causes StateManager.Replay returns an error with following message:

unexpected error during execution: callback failed on reward message: halt

@zl03jsj zl03jsj changed the title bugfix: StateManager.Replay fix: StateManager.Replay Mar 12, 2021
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@magik6k magik6k merged commit 53cba15 into filecoin-project:master Mar 25, 2021
@magik6k magik6k added the kind/bug Kind: Bug label Mar 25, 2021
@magik6k magik6k changed the title fix: StateManager.Replay fix: StateManager.Replay on reward actor Apr 13, 2021
@magik6k magik6k mentioned this pull request Apr 13, 2021
69 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants