-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust various CLI display ratios to arbitrary precision #6309
Conversation
6772cae
to
20fe10a
Compare
Originally the deviations from using float64 were insignificant, but at exabyte scale they start to show up. Cleanup all displays, and clarify the expectation text, adding an extra 99.9% probability calculator to `lotus-miner info`
20fe10a
to
c2e5a83
Compare
@BigLep @jennijuju I think we need to add this to the |
First of all, we normally add tickets not PR to milestone (dev work should generally starts with a ticket anyways). |
That's fine, we'll merge it when we merge it. |
Math looks correct, thanks @ribasushi for tackling this, this should reduce number of complaints of people having unlucky streaks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Math seems good, nice improvement overall!
Originally the deviations from using float64 were insignificant, but at
exabyte scale they start to show up. Cleanup all displays, and clarify
the expectation text, adding an extra 99.9% probability calculator to
lotus-miner info
Before:
After:
/cc @Kubuxu @nikkolasg