build appimage in CI #6384
Merged
build appimage in CI #6384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryschwartz
force-pushed
the
feat/ci-appimage-release
branch
from
986243c
to
9d3410d
Compare
|
I just did a dry run. I nerfed the publish script to only echo the publish commands and watched the circleci run. It looks like it works provided the CIRCLE_TAG is set. |
|
Discussion in lotus standup today - Stewards do not need to block on merging this in. @travisperson can do the review and we should merge this accordingly. |
magik6k
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build appimage and include it in the release.
The CI executor now is 20.04 so I updated the AppImage yaml to work there.
I updated the release scripts to include the appimage. I have not run through the release to verify that the bundle and release scripts work so be extra cautious reviewing that.
EDIT:
I ran a dry run for the release step; looks like it will succeed.