-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build snapcraft #6388
build snapcraft #6388
Conversation
6e9b035
to
0fba816
Compare
I made some changes to the snapchat build aside from adding the CI logic. Origionally, I was using the pre-built binaries and just copying them into the snap, and was using ubuntu "core18" as the snap base. With this base, the linking was compatible with the golang docker image (which is debian). However, but this turned out to be a headache to get all the linking right with the golang-16.4 docker image. The binaries built in the build-all step have enough incompatibilty with package versions that it was easier to simply re-build it for the snap. So now, the binary is built as part of the snap construction and is based on ubuntu 20.04 -- although it will be installable on any linux OS running snap. |
I made some improvements to make sure this works with strict confinement, and added more detail for https://snapcraft.io/lotus-filecoin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question.
publish snap to the snapcraft store