Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

Reduce the max allowed blob size to fit in a 32GiB CAR #30

Closed
masih opened this issue Jul 20, 2023 · 2 comments · Fixed by #38
Closed

Reduce the max allowed blob size to fit in a 32GiB CAR #30

masih opened this issue Jul 20, 2023 · 2 comments · Fixed by #38
Assignees
Labels
M2.0 Motion API Storage to Filecoin MVP This is included within the MVP

Comments

@masih
Copy link
Member

masih commented Jul 20, 2023

This number is actually too large to always fit in a single piece.
we need to:

  • incorporate bit padding ( actual max CAR Size 32GB * 127/128)
  • factor in extra CAR bytes for CIDS + Car Headers + UnixFS intermediate nodes
  • I wonder if we just standardize on something safe-ish like 31GB?

Originally posted by @hannahhoward in #26 (comment)

@TorfinnOlsen
Copy link
Collaborator

31 is a clean round number that leaves no room for confusion in my opinion. I gather that you lose a little storage this way, but atleast for testing purposes during MVP seems reasonable.

If however we think this is a long term limitation we're going to have to live with, and therefore once used at scale we're sacrificing a great deal of storage I'd say let's think through what a minimal capacity reduction would be.

@TorfinnOlsen TorfinnOlsen added M2.0 Motion API Storage to Filecoin MVP This is included within the MVP labels Jul 21, 2023
@masih
Copy link
Member Author

masih commented Jul 25, 2023

Going with 31Gi. We can increase as needed.

masih added a commit that referenced this issue Jul 25, 2023
Further to discussions surrounding the extra headroom needed for CAR
header etc. reduce the max accepted blob size to 31 Gi for the MVP.

Fixes #30
@masih masih closed this as completed in #38 Jul 25, 2023
masih added a commit that referenced this issue Jul 25, 2023
Further to discussions surrounding the extra headroom needed for CAR
header etc. reduce the max accepted blob size to 31 Gi for the MVP.

Fixes #30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
M2.0 Motion API Storage to Filecoin MVP This is included within the MVP
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants