feat: FVM no longer draws randomness for you #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1848 +/- ##
=======================================
Coverage ? 75.34%
=======================================
Files ? 149
Lines ? 14603
Branches ? 0
=======================================
Hits ? 11002
Misses ? 3601
Partials ? 0 |
Stebalien
approved these changes
Aug 17, 2023
fvm/src/kernel/default.rs
Outdated
Comment on lines
759
to
760
| // TODO | ||
| .on_get_randomness(), |
There was a problem hiding this comment.
Let's pass in the lookback length and put this "todo" in the price list itself (that way, all of our todos are in the price-list side of things and we can merge this before we necessarily have final gas numbers.
arajasek
force-pushed
the
asr/stop-hashing-randomness
branch
from
089a574
to
1f27adf
Compare
Stebalien
approved these changes
Aug 21, 2023
fvm/src/kernel/default.rs
Outdated
| let t = self.call_manager.charge_gas( | ||
| self.call_manager | ||
| .price_list() | ||
| .on_get_randomness(entropy.len()), | ||
| .on_get_randomness(self.call_manager.context().epoch - rand_epoch), |
There was a problem hiding this comment.
Suggested change
| .on_get_randomness(self.call_manager.context().epoch - rand_epoch), | |
| .on_get_randomness(current_epoch - rand_epoch), |
arajasek
force-pushed
the
asr/stop-hashing-randomness
branch
from
1f27adf
to
1f6c418
Compare
arajasek
force-pushed
the
asr/stop-hashing-randomness
branch
from
1f6c418
to
cc35c99
Compare
|
Nest step: disable conformance tests in |
Stebalien
approved these changes
Aug 25, 2023
fvm/src/kernel/default.rs
Outdated
| ) -> Result<[u8; RANDOMNESS_LENGTH]> { | ||
| let current_epoch = self.call_manager.context().epoch; | ||
| if rand_epoch > current_epoch { |
There was a problem hiding this comment.
FYI... it is possible to write this as:
Suggested change
| if rand_epoch > current_epoch { | |
| let lookback = current_epoch.checked_sub(rand_epoch) | |
| .ok_or_else(syscall_error!(IllegalArgument; "randomness epoch {} is in the future", rand_epoch))?; |
There was a problem hiding this comment.
(lets you skip the subtraction below)
There was a problem hiding this comment.
Not that you necessarily should do it this way. I just figured I'd let you know.
sdk/src/rand.rs
Outdated
Comment on lines
29
to
23
| round: ChainEpoch, | ||
| entropy: &[u8], | ||
| ) -> SyscallResult<[u8; RANDOMNESS_LENGTH]> { | ||
| let ret = unsafe { | ||
| sys::rand::get_beacon_randomness(dst, round, entropy.as_ptr(), entropy.len() as u32)? | ||
| }; | ||
| pub fn get_beacon_randomness(round: ChainEpoch) -> SyscallResult<[u8; RANDOMNESS_LENGTH]> { | ||
| let ret = unsafe { sys::rand::get_beacon_randomness(round)? }; | ||
| Ok(ret) |
There was a problem hiding this comment.
nit: no need for the temporary ret variable, the entire function can be written as:
unsafe { sys::rand::get_beacon_randomness(round) }
Stebalien
pushed a commit
that referenced
this pull request
Sep 21, 2023
* feat: FVM no longer draws randomness for you * update actors bundle * address review * disable Hygge test vectors
Stebalien
pushed a commit
that referenced
this pull request
Sep 21, 2023
* feat: FVM no longer draws randomness for you * update actors bundle * address review * disable Hygge test vectors
Stebalien
pushed a commit
that referenced
this pull request
Sep 21, 2023
* feat: FVM no longer draws randomness for you * update actors bundle * address review * disable Hygge test vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1847
I might need to iron out the FVM-actors-FVM dependencies for green CI, but should be reviewable.