feat: use cid-in-subdomain IPFS preview urls #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
|
YES! IT BLENDS! I've updated the github action to use cid-in-subdomain preview urls. can comfirm that the service worker loaded and informed me that that page could be offlined, and the local search feature works.
|
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
|
is this ready for review ? |
|
@hugomrdias yep, the bulk of the work is over in ipfs-github-action ipfs-shipyard/ipfs-github-action#3 |
hugomrdias
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to ipfs-github-action@v2 to get cid-in-subdomain preview urls
Fixes #1007
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io