Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add new api DagstoreInitializeStorage to load shard from piece storage #5032

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Jul 5, 2022

Related Issues

resolve: #4911

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <#issue number> <area>: <change being made>
    • example: fix: #1234 mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs, misc, perf, refactor, revert, style, test
    • area: venus, venus-messager, venus-miner, venus-gateway, venus-auth, venus-market, venus-sealer, venus-wallet, venus-cluster, api, chain, state, vm, data transfer, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in venus docs or Discussion Tutorials.
  • CI is green

@hunjixin hunjixin self-assigned this Jul 5, 2022
@hunjixin hunjixin requested a review from simlecode July 5, 2022 07:43
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #5032 (9363190) into master (e14afe4) will increase coverage by 0%.
The diff coverage is 0%.

❗ Current head 9363190 differs from pull request most recent head 7e4508e. Consider uploading reports for the commit 7e4508e to get more accurate results

@@          Coverage Diff           @@
##           master   #5032   +/-   ##
======================================
  Coverage      25%     25%           
======================================
  Files         597     597           
  Lines       65031   65042   +11     
======================================
+ Hits        16566   16575    +9     
- Misses      46301   46304    +3     
+ Partials     2164    2163    -1     

@hunjixin hunjixin changed the title feat:add api DagstoreInitializeStorage feat:add new api DagstoreInitializeStorage to load shard from piece storage Jul 6, 2022
@hunjixin hunjixin force-pushed the feat/build_index_in_specify_storage branch from 9363190 to 7e4508e Compare July 8, 2022 07:44
@hunjixin hunjixin requested a review from diwufeiwen July 8, 2022 07:54
Copy link
Contributor

@diwufeiwen diwufeiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hunjixin hunjixin merged commit d8da353 into master Jul 8, 2022
@zl03jsj zl03jsj deleted the feat/build_index_in_specify_storage branch July 14, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-market] support rebuild piece index
3 participants